Skip to content

Data Transformations #2191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 24 commits into from
Closed

Data Transformations #2191

wants to merge 24 commits into from

Conversation

danmurphy1217
Copy link
Contributor

Describe your change:

  • [x ] Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • [ x ] I have read CONTRIBUTING.md.
  • [ x ] This pull request is all my own work -- I have not plagiarized.
  • [ x ] I know that pull requests will not be merged if they fail the automated tests.
  • [ x ] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • [ x ] All new Python files are placed inside an existing directory.
  • [ x ] All filenames are in all lowercase characters with no spaces or dashes.
  • [ x ] All functions and variable names follow Python naming conventions.
  • [ x ] All function parameters and return values are annotated with Python type hints.
  • [ x ] All functions have doctests that pass the automated testing.
  • [ x ] All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • [ x ] If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

danmurphy1217 and others added 22 commits June 21, 2020 12:11
Co-authored-by: Christian Clauss <cclauss@me.com>
Co-authored-by: Christian Clauss <cclauss@me.com>
Co-authored-by: Christian Clauss <cclauss@me.com>
Co-authored-by: Christian Clauss <cclauss@me.com>
Co-authored-by: Christian Clauss <cclauss@me.com>
Co-authored-by: Christian Clauss <cclauss@me.com>
Co-authored-by: Christian Clauss <cclauss@me.com>
Co-authored-by: Christian Clauss <cclauss@me.com>
@danmurphy1217 danmurphy1217 changed the title Dan Data Transformations Jul 9, 2020
@TravisBuddy
Copy link

Hey @danmurphy1217,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: b937ffc0-c218-11ea-8e31-7fd6e6dac888

@danmurphy1217
Copy link
Contributor Author

Looks like my old commits are getting grouped into this pull request- sorry about that. Should I close this and open a new one for just the data_transformations.py file?

@cclauss
Copy link
Member

cclauss commented Jul 9, 2020

In the markdown checklist above, adding spaces on either side of the x breaks the markdown syntax.

  • check
  • [x ] not check

On the code, could we get the mean and standard deviation from https://docs.python.org/3/library/statistics.html and not round them? Rounding multiple times an a single calculation worries me.

@danmurphy1217
Copy link
Contributor Author

In the markdown checklist above, adding spaces on either side of the x breaks the markdown syntax.

  • check
  • [x ] not check

On the code, could we get the mean and standard deviation from https://docs.python.org/3/library/statistics.html and not round them? Rounding multiple times an a single calculation worries me.

Yes, I can change that. I am going to close this pull request and open a new one with the current version of the Python Algorithms repository (to avoid conflicts with my previous commits). That ok?

@cclauss
Copy link
Member

cclauss commented Jul 9, 2020

Sure. If you cannot rebase then close and open a new PR. Just add Replaces #2191 so we can follow the thread of comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants